Skip to content

[Analysis] Add hazard closure regression coverage#232

Merged
learncold merged 1 commit into
mainfrom
codex/issue-225-hazard-closure-regression
May 14, 2026
Merged

[Analysis] Add hazard closure regression coverage#232
learncold merged 1 commit into
mainfrom
codex/issue-225-hazard-closure-regression

Conversation

@SilverSupplier
Copy link
Copy Markdown
Collaborator

Summary

  • Add integrated fire/smoke exposure plus door closure reroute regression coverage.
  • Document v2 hazard limits: no FDS coupling, no FED calculation, no fire spread, and no smoke concentration field simulation.
  • Keep the stacked chain on top of Task-Hazard and closure replay visualization 추가 #224 without changing runtime production behavior.

Related Issue

Area

  • Engine
  • Domain
  • Application
  • Docs
  • Build
  • Analysis
  • Chore

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug
  • MSBuild no-app safecrowd_tests.vcxproj Debug x64
  • git diff --check
  • build/vs2022/windows-debug-no-app/Debug/safecrowd_tests.exe
  • Not run (reason below)

Risks / Follow-up

  • cmake/ctest presets were not run because this shell is using the generated Visual Studio projects directly; no-app MSBuild and the test binary passed.
  • App build was not rerun for Task-Hazard closure interaction regression 정리 #225 because the branch only changes docs and domain regression tests.

@SilverSupplier SilverSupplier requested a review from learncold as a code owner May 12, 2026 17:59
@learncold learncold force-pushed the codex/issue-224-hazard-closure-replay-visualization branch from d907532 to 28609ce Compare May 14, 2026 04:45
Base automatically changed from codex/issue-224-hazard-closure-replay-visualization to main May 14, 2026 04:47
@learncold learncold force-pushed the codex/issue-225-hazard-closure-regression branch from dc99d8b to 8bab15d Compare May 14, 2026 04:47
@learncold learncold merged commit 6bb638a into main May 14, 2026
2 checks passed
@learncold learncold deleted the codex/issue-225-hazard-closure-regression branch May 14, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task-Hazard closure interaction regression 정리

2 participants